mfd: arizona: Remove redundant register sync (b375e9f9) · Commits · 戴 / test

This soft reset used to be located after the register patch had been applied, but has since moved to before the patch is applied. At the new location there is no requirement to do a register sync as no register writes will have happened yet. Signed-off-by:

Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Signed-off-by:

Lee Jones <lee.jones@linaro.org>

drivers/mfd/arizona-core.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -777,8 +777,6 @@ int arizona_dev_init(struct arizona *arizona)

		/* If we have a /RESET GPIO we'll already be reset */
		if (!arizona->pdata.reset) {
		regcache_mark_dirty(arizona->regmap);

		ret = regmap_write(arizona->regmap, ARIZONA_SOFTWARE_RESET, 0);
		if (ret != 0) {
		dev_err(dev, "Failed to reset device: %d\n", ret);
		@@ -786,12 +784,6 @@ int arizona_dev_init(struct arizona *arizona)
		}

		msleep(1);

		ret = regcache_sync(arizona->regmap);
		if (ret != 0) {
		dev_err(dev, "Failed to sync device: %d\n", ret);
		goto err_reset;
		}
		}

		/* Ensure device startup is complete */

Admin message