Commit b36773c3 authored Oct 26, 2020 by Sudip Mukherjee Committed by Greg Kroah-Hartman Oct 29, 2020

misc: hisi_hikey_usb: use PTR_ERR_OR_ZERO



Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code,
we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then
doing 'return 0'.

Tested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lore.kernel.org/r/20201026180026.3350-1-sudipm.mukherjee@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3650b228

drivers/misc/hisi_hikey_usb.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -168,10 +168,7 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev,

		hisi_hikey_usb->reset = devm_gpiod_get(&pdev->dev, "hub_reset_en_gpio",
		GPIOD_OUT_HIGH);
		if (IS_ERR(hisi_hikey_usb->reset))
		return PTR_ERR(hisi_hikey_usb->reset);

		return 0;
		return PTR_ERR_OR_ZERO(hisi_hikey_usb->reset);
		}

		static int hisi_hikey_usb_probe(struct platform_device *pdev)

Admin message