Commit b35997d4 authored Jun 07, 2007 by Robert Peterson Committed by Steven Whitehouse Jul 09, 2007

[GFS2] Can't mount GFS2 file system on AoE device



This patch fixes bug 243131: Can't mount GFS2 file system on AoE device.
When using AoE devices with lock_nolock, there is no locking table, so
gfs2 (and gfs1) uses the superblock s_id.  This turns out to be the device
name in some cases.  In the case of AoE, the device contains a slash,
(e.g. "etherd/e1.1p2") which is an invalid character when we try to
register the table in sysfs.  This patch replaces the "/" with underscore.
Rather than add a new variable to the stack, I'm just reusing a (char *)
variable that's no longer used: table.

This code has been tested on the failing system using a RHEL5 patch.
The upstream code was tested by using gfs2_tool sb to interject a "/"
into the table name of a clustered gfs2 file system.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent e1cc8603

fs/gfs2/ops_fstype.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -145,6 +145,9 @@ static int init_names(struct gfs2_sbd *sdp, int silent)
		snprintf(sdp->sd_proto_name, GFS2_FSNAME_LEN, "%s", proto);
		snprintf(sdp->sd_table_name, GFS2_FSNAME_LEN, "%s", table);

		while ((table = strchr(sdp->sd_table_name, '/')))
		*table = '_';

		out:
		return error;
		}

Admin message