Commit b33f3706 authored by Stephen Boyd's avatar Stephen Boyd Committed by Greg Kroah-Hartman
Browse files

usb: Remove dev_err() usage after platform_get_irq() 



We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// <smpl>
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>

While we're here, remove braces on if statements that only have one
statement (manually).

Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20190730181557.90391-47-swboyd@chromium.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dcf8f7ec

drivers/usb/chipidea/core.c

+0 −1
Original line number Diff line number Diff line
@@ -1008,7 +1008,6 @@ static int ci_hdrc_probe(struct platform_device *pdev) 


	ci->irq = platform_get_irq(pdev, 0);

	if (ci->irq < 0) {

		dev_err(dev, "missing IRQ\n");

		ret = ci->irq;

		goto deinit_phy;

	}

drivers/usb/dwc2/platform.c

+1 −3
Original line number Diff line number Diff line
@@ -407,10 +407,8 @@ static int dwc2_driver_probe(struct platform_device *dev) 
	spin_lock_init(&hsotg->lock);



	hsotg->irq = platform_get_irq(dev, 0);

	if (hsotg->irq < 0) {

		dev_err(&dev->dev, "missing IRQ resource\n");

	if (hsotg->irq < 0)

		return hsotg->irq;

	}



	dev_dbg(hsotg->dev, "registering common handler for irq%d\n",

		hsotg->irq);

drivers/usb/dwc3/dwc3-keystone.c

+0 −1
Original line number Diff line number Diff line
@@ -112,7 +112,6 @@ static int kdwc3_probe(struct platform_device *pdev) 


	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(&pdev->dev, "missing irq\n");

		error = irq;

		goto err_irq;

	}

drivers/usb/dwc3/dwc3-omap.c

+1 −3
Original line number Diff line number Diff line
@@ -469,10 +469,8 @@ static int dwc3_omap_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, omap);



	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(dev, "missing IRQ resource: %d\n", irq);

	if (irq < 0)

		return irq;

	}



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	base = devm_ioremap_resource(dev, res);

drivers/usb/gadget/udc/aspeed-vhub/core.c

+0 −1
Original line number Diff line number Diff line
@@ -348,7 +348,6 @@ static int ast_vhub_probe(struct platform_device *pdev) 
	/* Find interrupt and install handler */

	vhub->irq = platform_get_irq(pdev, 0);

	if (vhub->irq < 0) {

		dev_err(&pdev->dev, "Failed to get interrupt\n");

		rc = vhub->irq;

		goto err;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE