Commit b3343a2a authored by John Fastabend's avatar John Fastabend Committed by Jeff Kirsher
Browse files

net, ixgbe: handle link local multicast addresses in SR-IOV mode 



In SR-IOV mode the PF driver acts as the uplink port and is
used to send control packets e.g. lldpad, stp, etc.

   eth0.1     eth0.2     eth0
   VF         VF         PF
   |          |          |   <-- stand-in for uplink
   |          |          |
  --------------------------
  |  Embedded Switch       |
  --------------------------
              |
             MAC   <-- uplink

But the embedded switch is setup to forward multicast addresses
to all interfaces both VFs and PF and onto the physical link.
This results in reserved MAC addresses used by control protocols
to be forwarded over the switch onto the VF.

In the LLDP case the PF sends an LLDPDU and it is currently
being forwarded to all the VFs who then see the PF as a peer.
This is incorrect.

This patch adds the multicast addresses to the RAR table in the
hardware to prevent this behavior.

Signed-off-by: default avatarJohn Fastabend <john.r.fastabend@intel.com>
Tested-by: default avatarPhil Schmitt <phillip.j.schmitt@intel.com>
Tested-by: default avatarSibai Li <sibai.li@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent a3013405

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+1 −1
Original line number Diff line number Diff line
@@ -6967,7 +6967,7 @@ static int ixgbe_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[], 
		return -EINVAL;

	}



	if (is_unicast_ether_addr(addr)) {

	if (is_unicast_ether_addr(addr) || is_link_local(addr)) {

		u32 rar_uc_entries = IXGBE_MAX_PF_MACVLANS;



		if (netdev_uc_count(dev) < rar_uc_entries)

drivers/net/ethernet/intel/ixgbevf/vf.c

+3 −0
Original line number Diff line number Diff line
@@ -331,6 +331,9 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw, 
	netdev_for_each_mc_addr(ha, netdev) {

		if (i == cnt)

			break;

		if (is_link_local(ha->addr))

			continue;



		vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr);

	}

include/linux/etherdevice.h

+19 −0
Original line number Diff line number Diff line
@@ -51,6 +51,25 @@ extern struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs, 
#define alloc_etherdev(sizeof_priv) alloc_etherdev_mq(sizeof_priv, 1)

#define alloc_etherdev_mq(sizeof_priv, count) alloc_etherdev_mqs(sizeof_priv, count, count)



/* Reserved Ethernet Addresses per IEEE 802.1Q */

static const u8 br_reserved_address[ETH_ALEN] = { 0x01, 0x80, 0xc2, 0x00, 0x00, 0x00 };



/**

 * is_link_local -  Determine if given Eth addr is a link local mcast address.

 * @addr: Pointer to a six-byte array containing the Ethernet address

 *

 * Return true if address is link local reserved addr (01:80:c2:00:00:0X) per

 * IEEE 802.1Q 8.6.3 Frame filtering.

 */

static inline int is_link_local(const unsigned char *dest)

{

	__be16 *a = (__be16 *)dest;

	static const __be16 *b = (const __be16 *)br_reserved_address;

	static const __be16 m = cpu_to_be16(0xfff0);



	return ((a[0] ^ b[0]) | (a[1] ^ b[1]) | ((a[2] ^ b[2]) & m)) == 0;

}



/**

 * is_zero_ether_addr - Determine if give Ethernet address is all zeros.

 * @addr: Pointer to a six-byte array containing the Ethernet address

net/bridge/br_device.c

+1 −1
Original line number Diff line number Diff line
@@ -356,7 +356,7 @@ void br_dev_setup(struct net_device *dev) 
	br->bridge_id.prio[0] = 0x80;

	br->bridge_id.prio[1] = 0x00;



	memcpy(br->group_addr, br_group_address, ETH_ALEN);

	memcpy(br->group_addr, br_reserved_address, ETH_ALEN);



	br->stp_enabled = BR_NO_STP;

	br->group_fwd_mask = BR_GROUPFWD_DEFAULT;

net/bridge/br_input.c

+0 −15
Original line number Diff line number Diff line
@@ -19,9 +19,6 @@ 
#include <linux/export.h>

#include "br_private.h"



/* Bridge group multicast address 802.1d (pg 51). */

const u8 br_group_address[ETH_ALEN] = { 0x01, 0x80, 0xc2, 0x00, 0x00, 0x00 };



/* Hook for brouter */

br_should_route_hook_t __rcu *br_should_route_hook __read_mostly;

EXPORT_SYMBOL(br_should_route_hook);
@@ -127,18 +124,6 @@ static int br_handle_local_finish(struct sk_buff *skb) 
	return 0;	 /* process further */

}



/* Does address match the link local multicast address.

 * 01:80:c2:00:00:0X

 */

static inline int is_link_local(const unsigned char *dest)

{

	__be16 *a = (__be16 *)dest;

	static const __be16 *b = (const __be16 *)br_group_address;

	static const __be16 m = cpu_to_be16(0xfff0);



	return ((a[0] ^ b[0]) | (a[1] ^ b[1]) | ((a[2] ^ b[2]) & m)) == 0;

}



/*

 * Return NULL if skb is handled

 * note: already called with rcu_read_lock

CRA Git | Maintained and supported by SUSTech CRA and CCSE