Commit b3300146 authored Apr 02, 2012 by Srinivas Kandagatla Committed by David S. Miller Apr 03, 2012

phy:icplus:fix Auto Power Saving in ip101a_config_init.



This patch fixes Auto Power Saving configuration in ip101a_config_init
which was broken as there is no phy register write followed after
setting IP101A_APS_ON flag.

This patch also fixes the return value of ip101a_config_init.

Without this patch ip101a_config_init returns 2 which is not an error
accroding to IS_ERR and the mac driver will continue accessing 2 as
valid pointer to phy_dev resulting in memory fault.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6fc8cc3f

drivers/net/phy/icplus.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -162,7 +162,8 @@ static int ip101a_g_config_init(struct phy_device *phydev)
		/* Enable Auto Power Saving mode */
		c = phy_read(phydev, IP10XX_SPEC_CTRL_STATUS);
		c \|= IP101A_G_APS_ON;
		return c;

		return phy_write(phydev, IP10XX_SPEC_CTRL_STATUS, c);
		}

		static int ip175c_read_status(struct phy_device *phydev)

Admin message