Commit b329becf authored Aug 09, 2010 by Akinobu Mita Committed by Linus Torvalds Aug 09, 2010

char: add WARN_ON() in misc_deregister()



misc_deregister() returns an error only when it attempts to unregister
the device that is not registered. This is the driver's bug.

Most of the drivers don't check the return value of misc_deregister().
(It is not bad thing because most of kernel *_unregister() API always
succeed and do not return value)

So it is better to indicate the error by WARN_ON() in misc_deregister().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 878ae127

drivers/char/misc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -242,7 +242,7 @@ int misc_deregister(struct miscdevice *misc)
		{
		int i = DYNAMIC_MINORS - misc->minor - 1;

		if (list_empty(&misc->list))
		if (WARN_ON(list_empty(&misc->list)))
		return -EINVAL;

		mutex_lock(&misc_mtx);

Admin message