Commit b311da85 authored Aug 13, 2019 by Rodrigo Ribeiro Committed by Jonathan Cameron Aug 18, 2019

staging: iio: accel: adis16240: Improve readability on write_raw function



Replace shift and minus operation by GENMASK macro and remove the local
variables used to store intermediate data.

Signed-off-by: Rodrigo Ribeiro Carvalho <rodrigorsdc@gmail.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 62ed7a81

drivers/staging/iio/accel/adis16240.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -309,15 +309,12 @@ static int adis16240_write_raw(struct iio_dev *indio_dev,
		long mask)
		{
		struct adis *st = iio_priv(indio_dev);
		int bits = 10;
		s16 val16;
		u8 addr;

		switch (mask) {
		case IIO_CHAN_INFO_CALIBBIAS:
		val16 = val & ((1 << bits) - 1);
		addr = adis16240_addresses[chan->scan_index][0];
		return adis_write_reg_16(st, addr, val16);
		return adis_write_reg_16(st, addr, val & GENMASK(9, 0));
		}
		return -EINVAL;
		}

Admin message