Commit b2f8fb23 authored Jan 21, 2011 by Dr. David Alan Gilbert Committed by Arnaldo Carvalho de Melo Jan 21, 2011

perf symbols: Fix annotation of thumb code

In ARM's Thumb mode the bottom bit of the symbol address is set to mark
the function as Thumb; the instructions are in reality 2 or 4 byte on 2
byte alignments, and when the +1 address is used in annotate it causes
objdump to disassemble invalid instructions.

The patch removes that bottom bit during symbol loading.

Many thinks to Dave Martin for comments on an initial version of the
patch.

(For reference this corresponds to this bug
https://bugs.launchpad.net/linux-linaro/+bug/677547

 )

Cc: Ingo Molnar <mingo@elte.hu>
Cc: Dave Martin <dave.martin@linaro.org>
LKML-Reference: <20110121163922.GA31398@davesworkthinkpad>
Signed-off-by: Dr. David Alan Gilbert <david.gilbert@linaro.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 547e9fd7

tools/perf/util/symbol.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1161,6 +1161,13 @@ static int dso__load_sym(struct dso self, struct map map, const char *name,

		section_name = elf_sec__name(&shdr, secstrs);

		/* On ARM, symbols for thumb functions have 1 added to
		* the symbol address as a flag - remove it */
		if ((ehdr.e_machine == EM_ARM) &&
		(map->type == MAP__FUNCTION) &&
		(sym.st_value & 1))
		--sym.st_value;

		if (self->kernel != DSO_TYPE_USER \|\| kmodule) {
		char dso_name[PATH_MAX];

Admin message