Commit b2ca8800 authored Mar 10, 2020 by Stephen Boyd Committed by Wolfram Sang Mar 13, 2020

i2c: qcom-geni: Let firmware specify irq trigger flags



We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables
should take care of this for us. Just use 0 instead so that we use the
flags from the firmware. Also, remove specify dev_name() for the irq
name so that we can get better information in /proc/interrupts about
which device is generating interrupts.

Cc: Alok Chauhan <alokc@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent bf22461e

drivers/i2c/busses/i2c-qcom-geni.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -549,8 +549,8 @@ static int geni_i2c_probe(struct platform_device *pdev)
		init_completion(&gi2c->done);
		spin_lock_init(&gi2c->lock);
		platform_set_drvdata(pdev, gi2c);
		ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq,
		IRQF_TRIGGER_HIGH, "i2c_geni", gi2c);
		ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq, 0,
		dev_name(&pdev->dev), gi2c);
		if (ret) {
		dev_err(&pdev->dev, "Request_irq failed:%d: err:%d\n",
		gi2c->irq, ret);

Admin message