Commit b2c586eb authored by Minas Harutyunyan's avatar Minas Harutyunyan Committed by Felipe Balbi
Browse files

usb: dwc2: Fix INTR OUT transfers in DDMA mode. 



In DDMA mode if INTR OUT transfers mps not multiple of 4 then single packet
corresponds to single descriptor.

Descriptor limit set to mps and desc chain limit set to mps *
MAX_DMA_DESC_NUM_GENERIC. On that descriptors complete, to calculate
transfer size should be considered correction value for each descriptor.

In start request function, if "continue" is true then dma buffer address
should be incremmented by offset for all type of transfers, not only for
Control DATA_OUT transfers.

Fixes: cf77b5fb ("usb: dwc2: gadget: Transfer length limit checking for DDMA")
Fixes: e02f9aa6 ("usb: dwc2: gadget: EP 0 specific DDMA programming")
Fixes: aa3e8bc8 ("usb: dwc2: gadget: DDMA transfer start and complete")

Signed-off-by: default avatarMinas Harutyunyan <hminas@synopsys.com>
Signed-off-by: default avatarFelipe Balbi <balbi@kernel.org>
parent d58ba480

drivers/usb/dwc2/gadget.c

+33 −7
Original line number Diff line number Diff line
@@ -713,8 +713,11 @@ static u32 dwc2_hsotg_read_frameno(struct dwc2_hsotg *hsotg) 
 */

static unsigned int dwc2_gadget_get_chain_limit(struct dwc2_hsotg_ep *hs_ep)

{

	const struct usb_endpoint_descriptor *ep_desc = hs_ep->ep.desc;

	int is_isoc = hs_ep->isochronous;

	unsigned int maxsize;

	u32 mps = hs_ep->ep.maxpacket;

	int dir_in = hs_ep->dir_in;



	if (is_isoc)

		maxsize = (hs_ep->dir_in ? DEV_DMA_ISOC_TX_NBYTES_LIMIT :
@@ -723,6 +726,11 @@ static unsigned int dwc2_gadget_get_chain_limit(struct dwc2_hsotg_ep *hs_ep) 
	else

		maxsize = DEV_DMA_NBYTES_LIMIT * MAX_DMA_DESC_NUM_GENERIC;



	/* Interrupt OUT EP with mps not multiple of 4 */

	if (hs_ep->index)

		if (usb_endpoint_xfer_int(ep_desc) && !dir_in && (mps % 4))

			maxsize = mps * MAX_DMA_DESC_NUM_GENERIC;



	return maxsize;

}
@@ -738,11 +746,14 @@ static unsigned int dwc2_gadget_get_chain_limit(struct dwc2_hsotg_ep *hs_ep) 
 * Isochronous - descriptor rx/tx bytes bitfield limit,

 * Control In/Bulk/Interrupt - multiple of mps. This will allow to not

 * have concatenations from various descriptors within one packet.

 * Interrupt OUT - if mps not multiple of 4 then a single packet corresponds

 * to a single descriptor.

 *

 * Selects corresponding mask for RX/TX bytes as well.

 */

static u32 dwc2_gadget_get_desc_params(struct dwc2_hsotg_ep *hs_ep, u32 *mask)

{

	const struct usb_endpoint_descriptor *ep_desc = hs_ep->ep.desc;

	u32 mps = hs_ep->ep.maxpacket;

	int dir_in = hs_ep->dir_in;

	u32 desc_size = 0;
@@ -766,6 +777,13 @@ static u32 dwc2_gadget_get_desc_params(struct dwc2_hsotg_ep *hs_ep, u32 *mask) 
		desc_size -= desc_size % mps;

	}



	/* Interrupt OUT EP with mps not multiple of 4 */

	if (hs_ep->index)

		if (usb_endpoint_xfer_int(ep_desc) && !dir_in && (mps % 4)) {

			desc_size = mps;

			*mask = DEV_DMA_NBYTES_MASK;

		}



	return desc_size;

}
@@ -1123,13 +1141,7 @@ static void dwc2_hsotg_start_req(struct dwc2_hsotg *hsotg, 
				length += (mps - (length % mps));

		}



		/*

		 * If more data to send, adjust DMA for EP0 out data stage.

		 * ureq->dma stays unchanged, hence increment it by already

		 * passed passed data count before starting new transaction.

		 */

		if (!index && hsotg->ep0_state == DWC2_EP0_DATA_OUT &&

		    continuing)

		if (continuing)

			offset = ureq->actual;



		/* Fill DDMA chain entries */
@@ -2320,22 +2332,36 @@ static void dwc2_hsotg_change_ep_iso_parity(struct dwc2_hsotg *hsotg, 
 */

static unsigned int dwc2_gadget_get_xfersize_ddma(struct dwc2_hsotg_ep *hs_ep)

{

	const struct usb_endpoint_descriptor *ep_desc = hs_ep->ep.desc;

	struct dwc2_hsotg *hsotg = hs_ep->parent;

	unsigned int bytes_rem = 0;

	unsigned int bytes_rem_correction = 0;

	struct dwc2_dma_desc *desc = hs_ep->desc_list;

	int i;

	u32 status;

	u32 mps = hs_ep->ep.maxpacket;

	int dir_in = hs_ep->dir_in;



	if (!desc)

		return -EINVAL;



	/* Interrupt OUT EP with mps not multiple of 4 */

	if (hs_ep->index)

		if (usb_endpoint_xfer_int(ep_desc) && !dir_in && (mps % 4))

			bytes_rem_correction = 4 - (mps % 4);



	for (i = 0; i < hs_ep->desc_count; ++i) {

		status = desc->status;

		bytes_rem += status & DEV_DMA_NBYTES_MASK;

		bytes_rem -= bytes_rem_correction;



		if (status & DEV_DMA_STS_MASK)

			dev_err(hsotg->dev, "descriptor %d closed with %x\n",

				i, status & DEV_DMA_STS_MASK);



		if (status & DEV_DMA_L)

			break;



		desc++;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE