Commit b2b1d94c authored Dec 16, 2019 by Jan Beulich Committed by Borislav Petkov Jan 09, 2020

x86/entry/64: Add instruction suffix to SYSRET



ignore_sysret() contains an unsuffixed SYSRET instruction. gas correctly
interprets this as SYSRETL, but leaving it up to gas to guess when there
is no register operand that implies a size is bad practice, and upstream
gas is likely to warn about this in the future. Use SYSRETL explicitly.
This does not change the assembled output.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Andy Lutomirski <luto@kernel.org>
Link: https://lkml.kernel.org/r/038a7c35-062b-a285-c6d2-653b56585844@suse.com

parent 2b10906f

arch/x86/entry/entry_64.S

+1 −1

Original line number	Diff line number	Diff line
		@@ -1728,7 +1728,7 @@ SYM_CODE_END(nmi)
		SYM_CODE_START(ignore_sysret)
		UNWIND_HINT_EMPTY
		mov $-ENOSYS, %eax
		sysret
		sysretl
		SYM_CODE_END(ignore_sysret)
		#endif

Admin message