ASoC: soc-core: Add dynamic debug logs in soc_dai_link_sanity_check() (b2acc24c) · Commits · 戴 / test

When a platform device is created successfully but the machine driver probe fails due to errors with missing components during the card bind stage, no error is propagated or logged. To help flag such problems, add a dynamic debug log. Signed-off-by:

Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by:

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by:

Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> Reviewed-by:

Daniel Baluta <daniel.baluta@gmail.com> Reviewed-by:

Kai Vehmanen <kai.vehmanen@linux.intel.com> Link: https://lore.kernel.org/r/20200409184416.15591-5-pierre-louis.bossart@linux.intel.com Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/soc-core.c

+15 −3

Original line number	Diff line number	Diff line
		@@ -865,9 +865,13 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card,
		* Defer card registration if codec component is not added to
		* component list.
		*/
		if (!soc_find_component(codec))
		if (!soc_find_component(codec)) {
		dev_dbg(card->dev,
		"ASoC: codec component %s not found for link %s\n",
		codec->name, link->name);
		return -EPROBE_DEFER;
		}
		}

		for_each_link_platforms(link, i, platform) {
		/*
		@@ -886,9 +890,13 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card,
		* Defer card registration if platform component is not added to
		* component list.
		*/
		if (!soc_find_component(platform))
		if (!soc_find_component(platform)) {
		dev_dbg(card->dev,
		"ASoC: platform component %s not found for link %s\n",
		platform->name, link->name);
		return -EPROBE_DEFER;
		}
		}

		for_each_link_cpus(link, i, cpu) {
		/*
		@@ -908,8 +916,12 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card,
		* component list.
		*/
		if ((cpu->of_node \|\| cpu->name) &&
		!soc_find_component(cpu))
		!soc_find_component(cpu)) {
		dev_dbg(card->dev,
		"ASoC: cpu component %s not found for link %s\n",
		cpu->name, link->name);
		return -EPROBE_DEFER;
		}

		/*
		* At least one of CPU DAI name or CPU device name/node must be

Admin message