Commit b2aaaa3b authored Jul 05, 2013 by Josef Bacik Committed by Chris Mason Sep 01, 2013

Btrfs: set lockdep class before locking new extent buffer

We've been seeing spurious complaints out of lockdep because the lock class name
changes. This is happening because when we drop a snapshot we will lock a block
before we've read it in, which sets the lockdep class to whatever the default
is. Then once we read the thing in we reset the lockdep class to what it is
supposed to be, which blows lockdeps' mind. This patch should fix the problem,
it appears to be the only place where we do this sort of thing. Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>

parent 59516f60

fs/btrfs/extent-tree.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -7173,6 +7173,8 @@ static noinline int do_walk_down(struct btrfs_trans_handle *trans,
		next = btrfs_find_create_tree_block(root, bytenr, blocksize);
		if (!next)
		return -ENOMEM;
		btrfs_set_buffer_lockdep_class(root->root_key.objectid, next,
		level - 1);
		reada = 1;
		}
		btrfs_tree_lock(next);

Admin message