powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler (b29336c0) · Commits · 戴 / test

Fixes: ("powernv/opal-dump: Convert to irq domain") Converts all the return explicit number to a more proper IRQ_HANDLED, which looks proper incase of interrupt handler returning case. Here, It also removes error message like "nobody cared" which was getting unveiled while returning -1 or 0 from handler. Signed-off-by:

Mukesh Ojha <mukesh02@linux.vnet.ibm.com> Reviewed-by:

Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by:

Michael Ellerman <mpe@ellerman.id.au>

arch/powerpc/platforms/powernv/opal-dump.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -371,13 +371,12 @@ static irqreturn_t process_dump(int irq, void *data)
		{
		int rc;
		uint32_t dump_id, dump_size, dump_type;
		struct dump_obj *dump;
		char name[22];
		struct kobject *kobj;

		rc = dump_read_info(&dump_id, &dump_size, &dump_type);
		if (rc != OPAL_SUCCESS)
		return rc;
		return IRQ_HANDLED;

		sprintf(name, "0x%x-0x%x", dump_type, dump_id);

		@@ -389,12 +388,10 @@ static irqreturn_t process_dump(int irq, void *data)
		if (kobj) {
		/* Drop reference added by kset_find_obj() */
		kobject_put(kobj);
		return 0;
		return IRQ_HANDLED;
		}

		dump = create_dump_obj(dump_id, dump_size, dump_type);
		if (!dump)
		return -1;
		create_dump_obj(dump_id, dump_size, dump_type);

		return IRQ_HANDLED;
		}

Admin message