Commit b28b1f0c authored by Qu Wenruo's avatar Qu Wenruo Committed by David Sterba
Browse files

btrfs: delayed-ref: Introduce better documented delayed ref structures 



Current delayed ref interface has several problems:

- Longer and longer parameter lists
  bytenr
  num_bytes
  parent
  ---------- so far so good
  ref_root
  owner
  offset
  ---------- I don't feel good now

- Different interpretation of the same parameter

  Above @owner for data ref is inode number (u64),
  while for tree ref, it's level (int).

  They are even in different size range.
  For level we only need 0 ~ 8, while for ino it's
  BTRFS_FIRST_FREE_OBJECTID ~ BTRFS_LAST_FREE_OBJECTID.

  And @offset doesn't even make sense for tree ref.

  Such parameter reuse may look clever as an hidden union, but it
  destroys code readability.

To solve both problems, we introduce a new structure, btrfs_ref to solve
them:

- Structure instead of long parameter list
  This makes later expansion easier, and is better documented.

- Use btrfs_ref::type to distinguish data and tree ref

- Use proper union to store data/tree ref specific structures.

- Use separate functions to fill data/tree ref data, with a common generic
  function to fill common bytenr/num_bytes members.

All parameters will find its place in btrfs_ref, and an extra member,
@real_root, inspired by ref-verify code, is newly introduced for later
qgroup code, to record which tree is triggered by this extent modification.

This patch doesn't touch any code, but provides the basis for further
refactoring.

Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent bfc61c36

fs/btrfs/delayed-ref.h

+109 −0
Original line number Diff line number Diff line
@@ -176,6 +176,83 @@ struct btrfs_delayed_ref_root { 
	u64 qgroup_to_skip;

};



enum btrfs_ref_type {

	BTRFS_REF_NOT_SET,

	BTRFS_REF_DATA,

	BTRFS_REF_METADATA,

	BTRFS_REF_LAST,

};



struct btrfs_data_ref {

	/* For EXTENT_DATA_REF */



	/* Root which refers to this data extent */

	u64 ref_root;



	/* Inode which refers to this data extent */

	u64 ino;



	/*

	 * file_offset - extent_offset

	 *

	 * file_offset is the key.offset of the EXTENT_DATA key.

	 * extent_offset is btrfs_file_extent_offset() of the EXTENT_DATA data.

	 */

	u64 offset;

};



struct btrfs_tree_ref {

	/*

	 * Level of this tree block

	 *

	 * Shared for skinny (TREE_BLOCK_REF) and normal tree ref.

	 */

	int level;



	/*

	 * Root which refers to this tree block.

	 *

	 * For TREE_BLOCK_REF (skinny metadata, either inline or keyed)

	 */

	u64 root;



	/* For non-skinny metadata, no special member needed */

};



struct btrfs_ref {

	enum btrfs_ref_type type;

	int action;



	/*

	 * Whether this extent should go through qgroup record.

	 *

	 * Normally false, but for certain cases like delayed subtree scan,

	 * setting this flag can hugely reduce qgroup overhead.

	 */

	bool skip_qgroup;



	/*

	 * Optional. For which root is this modification.

	 * Mostly used for qgroup optimization.

	 *

	 * When unset, data/tree ref init code will populate it.

	 * In certain cases, we're modifying reference for a different root.

	 * E.g. COW fs tree blocks for balance.

	 * In that case, tree_ref::root will be fs tree, but we're doing this

	 * for reloc tree, then we should set @real_root to reloc tree.

	 */

	u64 real_root;

	u64 bytenr;

	u64 len;



	/* Bytenr of the parent tree block */

	u64 parent;

	union {

		struct btrfs_data_ref data_ref;

		struct btrfs_tree_ref tree_ref;

	};

};



extern struct kmem_cache *btrfs_delayed_ref_head_cachep;

extern struct kmem_cache *btrfs_delayed_tree_ref_cachep;

extern struct kmem_cache *btrfs_delayed_data_ref_cachep;
@@ -184,6 +261,38 @@ extern struct kmem_cache *btrfs_delayed_extent_op_cachep; 
int __init btrfs_delayed_ref_init(void);

void __cold btrfs_delayed_ref_exit(void);



static inline void btrfs_init_generic_ref(struct btrfs_ref *generic_ref,

				int action, u64 bytenr, u64 len, u64 parent)

{

	generic_ref->action = action;

	generic_ref->bytenr = bytenr;

	generic_ref->len = len;

	generic_ref->parent = parent;

}



static inline void btrfs_init_tree_ref(struct btrfs_ref *generic_ref,

				int level, u64 root)

{

	/* If @real_root not set, use @root as fallback */

	if (!generic_ref->real_root)

		generic_ref->real_root = root;

	generic_ref->tree_ref.level = level;

	generic_ref->tree_ref.root = root;

	generic_ref->type = BTRFS_REF_METADATA;

}



static inline void btrfs_init_data_ref(struct btrfs_ref *generic_ref,

				u64 ref_root, u64 ino, u64 offset)

{

	/* If @real_root not set, use @root as fallback */

	if (!generic_ref->real_root)

		generic_ref->real_root = ref_root;

	generic_ref->data_ref.ref_root = ref_root;

	generic_ref->data_ref.ino = ino;

	generic_ref->data_ref.offset = offset;

	generic_ref->type = BTRFS_REF_DATA;

}



static inline struct btrfs_delayed_extent_op *

btrfs_alloc_delayed_extent_op(void)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE