Commit b24e03db authored by Josef Bacik's avatar Josef Bacik
Browse files

Btrfs: release trans metadata bytes before flushing delayed refs 



We started setting trans->block_rsv = NULL to allow the delayed refs flushing
stuff to use the right block_rsv and then just made
btrfs_trans_release_metadata() unconditionally use the trans block rsv.  The
problem with this is we need to reserve some space in the transaction and then
migrate it to the global block rsv, so we need to be able to free that out
properly.  So instead just move btrfs_trans_release_metadata() before the
delayed ref flushing and use trans->block_rsv for the freeing.  Thanks,

Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
parent 877da174

fs/btrfs/extent-tree.c

+1 −4
Original line number Diff line number Diff line
@@ -3909,13 +3909,10 @@ static void release_global_block_rsv(struct btrfs_fs_info *fs_info) 
void btrfs_trans_release_metadata(struct btrfs_trans_handle *trans,

				  struct btrfs_root *root)

{

	struct btrfs_block_rsv *block_rsv;



	if (!trans->bytes_reserved)

		return;



	block_rsv = &root->fs_info->trans_block_rsv;

	btrfs_block_rsv_release(root, block_rsv, trans->bytes_reserved);

	btrfs_block_rsv_release(root, trans->block_rsv, trans->bytes_reserved);

	trans->bytes_reserved = 0;

}

fs/btrfs/transaction.c

+2 −4
Original line number Diff line number Diff line
@@ -462,6 +462,7 @@ static int __btrfs_end_transaction(struct btrfs_trans_handle *trans, 
		return 0;

	}



	btrfs_trans_release_metadata(trans, root);

	trans->block_rsv = NULL;

	while (count < 4) {

		unsigned long cur = trans->delayed_ref_updates;
@@ -483,8 +484,6 @@ static int __btrfs_end_transaction(struct btrfs_trans_handle *trans, 
		count++;

	}



	btrfs_trans_release_metadata(trans, root);



	if (lock && !atomic_read(&root->fs_info->open_ioctl_trans) &&

	    should_end_transaction(trans, root)) {

		trans->transaction->blocked = 1;
@@ -1128,6 +1127,7 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans, 


	btrfs_run_ordered_operations(root, 0);



	btrfs_trans_release_metadata(trans, root);

	trans->block_rsv = NULL;



	/* make a pass through all the delayed refs we have so far
@@ -1136,8 +1136,6 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans, 
	ret = btrfs_run_delayed_refs(trans, root, 0);

	BUG_ON(ret);



	btrfs_trans_release_metadata(trans, root);



	cur_trans = trans->transaction;

	/*

	 * set the flushing flag so procs in this transaction have to

CRA Git | Maintained and supported by SUSTech CRA and CCSE