Unverified Commit b239d0c2 authored by Rob Herring's avatar Rob Herring Committed by Mark Brown
Browse files

ASoC: dt-bindings: google, cros-ec-codec: Fix dtc warnings in example



Extra dtc warnings (roughly what W=1 enables) are now enabled by default
when building the binding examples. These were fixed treewide in
5.6-rc5, but the newly added google,cros-ec-codec schema adds some new
warnings:

Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:17.28-21.11:
Warning (unit_address_vs_reg): /example-0/reserved_mem: node has a reg or ranges property, but no unit name
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:22.19-32.11:
Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg property
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.37-31.15:
Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name

Fixing the above, then results in:

Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:26.13-23:
Warning (reg_format): /example-0/cros-ec@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/sound/google,cros-ec-codec.example.dts:27.37-32.15:
Warning (unit_address_vs_reg): /example-0/cros-ec@0/ec-codec: node has a reg or ranges property, but no unit name

Fixes: eadd54c7 ("dt-bindings: Convert the binding file google, cros-ec-codec.txt to yaml format.")
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: alsa-devel@alsa-project.org
Cc: Benson Leung <bleung@chromium.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Cheng-Yi Chiang <cychiang@chromium.org>
Link: https://lore.kernel.org/r/20200311205841.2710-1-robh@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4d90a4e6
Loading
Loading
Loading
Loading
+16 −11
Original line number Diff line number Diff line
@@ -44,19 +44,24 @@ additionalProperties: false

examples:
  - |
    reserved_mem: reserved_mem {
    reserved_mem: reserved-mem@52800000 {
        compatible = "shared-dma-pool";
        reg = <0 0x52800000 0 0x100000>;
        reg = <0x52800000 0x100000>;
        no-map;
    };
    spi {
        #address-cells = <1>;
        #size-cells = <0>;
        cros-ec@0 {
            compatible = "google,cros-ec-spi";
            #address-cells = <2>;
            #size-cells = <1>;
        cros_ec_codec: ec-codec {
            reg = <0>;
            cros_ec_codec: ec-codec@10500000 {
                compatible = "google,cros-ec-codec";
                #sound-dai-cells = <1>;
                reg = <0x0 0x10500000 0x80000>;
                memory-region = <&reserved_mem>;
            };
        };
    };