perf debug: No need to include ui/util.h (b22bb139) · Commits · 戴 / test

Nothing from that file is used in util/debug.h, it is only needed in some places that get it indirectly via including util/debug.h, remove that entanglement. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://lkml.kernel.org/n/tip-hn9v4jdova2nt018fqsjyzun@git.kernel.org Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/ui/browsers/scripts.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2,6 +2,7 @@
		#include "../../builtin.h"
		#include "../../perf.h"
		#include "../../util/util.h"
		#include "../util.h"
		#include "../../util/hist.h"
		#include "../../util/debug.h"
		#include "../../util/symbol.h"

tools/perf/ui/gtk/setup.c

+2 −1

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0
		#include "gtk.h"
		#include "../../util/debug.h"
		#include <linux/compiler.h>
		#include "../util.h"

		extern struct perf_error_ops perf_gtk_eops;

tools/perf/util/debug.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -3,9 +3,9 @@
		#ifndef __PERF_DEBUG_H
		#define __PERF_DEBUG_H

		#include <stdarg.h>
		#include <stdbool.h>
		#include <linux/compiler.h>
		#include "../ui/util.h"

		extern int verbose;
		extern bool quiet, dump_trace;

Admin message