Commit b210b3bb authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf ui browser: Introduce ui_browser__show_title 



Needed because we were only showing the title in ui_browser__show,
not in ui_browser__run, and in the run loop we may be calling other
browsers that would then change the title, when we go back to the
previous browser, we need to redraw the title.

We could have done this as the Newt help line, with pop, etc, but I
don't think its worth, doing it explicitely, when needed (some browsers
may not use the title area at all) seems enough/more flexible.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent c16bfe9a

tools/perf/util/ui/browser.c

+15 −3
Original line number Diff line number Diff line
@@ -157,6 +157,20 @@ void ui_browser__add_exit_keys(struct ui_browser *self, int keys[]) 
	}

}



void __ui_browser__show_title(struct ui_browser *browser, const char *title)

{

	SLsmg_gotorc(0, 0);

	ui_browser__set_color(browser, NEWT_COLORSET_ROOT);

	slsmg_write_nstring(title, browser->width);

}



void ui_browser__show_title(struct ui_browser *browser, const char *title)

{

	pthread_mutex_lock(&ui__lock);

	__ui_browser__show_title(browser, title);

	pthread_mutex_unlock(&ui__lock);

}



int ui_browser__show(struct ui_browser *self, const char *title,

		     const char *helpline, ...)

{
@@ -180,9 +194,7 @@ int ui_browser__show(struct ui_browser *self, const char *title, 
		return -1;



	pthread_mutex_lock(&ui__lock);

	SLsmg_gotorc(0, 0);

	ui_browser__set_color(self, NEWT_COLORSET_ROOT);

	slsmg_write_nstring(title, self->width);

	__ui_browser__show_title(self, title);



	ui_browser__add_exit_keys(self, keys);

	newtFormAddComponent(self->form, self->sb);

tools/perf/util/ui/browser.h

+2 −1
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ struct ui_browser { 
	u32	      nr_entries;

};





void ui_browser__set_color(struct ui_browser *self, int color);

void ui_browser__set_percent_color(struct ui_browser *self,

				   double percent, bool current);
@@ -35,6 +34,8 @@ void ui_browser__reset_index(struct ui_browser *self); 
void ui_browser__gotorc(struct ui_browser *self, int y, int x);

void ui_browser__add_exit_key(struct ui_browser *self, int key);

void ui_browser__add_exit_keys(struct ui_browser *self, int keys[]);

void __ui_browser__show_title(struct ui_browser *browser, const char *title);

void ui_browser__show_title(struct ui_browser *browser, const char *title);

int ui_browser__show(struct ui_browser *self, const char *title,

		     const char *helpline, ...);

void ui_browser__hide(struct ui_browser *self);

CRA Git | Maintained and supported by SUSTech CRA and CCSE