Commit b2108f1e authored Nov 04, 2014 by Peter Chen Committed by Greg Kroah-Hartman Nov 03, 2014

usb: core: notify disconnection when core detects disconnect



It is safe to call notify disconnect when the usb core
thinks the device is disconnected.

This commit also fixes one bug found at below situation:
we have not enabled usb wakeup, we do system suspend when
there is an usb device at the port, after suspend, we plug out
the usb device, then plug in device again. At that time,
the nofity disconnect was not called at current code, as
the controller doesn't know the usb device was disconnected
during the suspend, but USB core knows the port has changed
during that periods.

So to fix this problem, and let the usb core call notify disconnect.

Cc: 3.17+ <stable@vger.kernel.org>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 01ed67dc

drivers/usb/core/hub.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -4624,8 +4624,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus,

		/* Disconnect any existing devices under this port */
		if (udev) {
		if (hcd->usb_phy && !hdev->parent &&
		!(portstatus & USB_PORT_STAT_CONNECTION))
		if (hcd->usb_phy && !hdev->parent)
		usb_phy_notify_disconnect(hcd->usb_phy, udev->speed);
		usb_disconnect(&port_dev->child);
		}

Admin message