Commit b201c111 authored by Viresh Kumar's avatar Viresh Kumar Committed by Vinod Koul
Browse files

dmaengine/amba-pl08x: pass (*ptr) to sizeof() instead of (struct xyz) 



As mentioned in Documentation/CodingStyle,

The preferred form for passing a size of a struct is the following:
   p = kmalloc(sizeof(*p), ...);

The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not.

This patch replaces (struct xyz) with *ptr at several occurrences in driver.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@st.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 0c38d701

drivers/dma/amba-pl08x.c

+4 −4
Original line number Diff line number Diff line
@@ -1293,7 +1293,7 @@ static int pl08x_prep_channel_resources(struct pl08x_dma_chan *plchan, 
static struct pl08x_txd *pl08x_get_txd(struct pl08x_dma_chan *plchan,

	unsigned long flags)

{

	struct pl08x_txd *txd = kzalloc(sizeof(struct pl08x_txd), GFP_NOWAIT);

	struct pl08x_txd *txd = kzalloc(sizeof(*txd), GFP_NOWAIT);



	if (txd) {

		dma_async_tx_descriptor_init(&txd->tx, &plchan->chan);
@@ -1690,7 +1690,7 @@ static int pl08x_dma_init_virtual_channels(struct pl08x_driver_data *pl08x, 
	 * to cope with that situation.

	 */

	for (i = 0; i < channels; i++) {

		chan = kzalloc(sizeof(struct pl08x_dma_chan), GFP_KERNEL);

		chan = kzalloc(sizeof(*chan), GFP_KERNEL);

		if (!chan) {

			dev_err(&pl08x->adev->dev,

				"%s no memory for channel\n", __func__);
@@ -1850,7 +1850,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id) 
		return ret;



	/* Create the driver state holder */

	pl08x = kzalloc(sizeof(struct pl08x_driver_data), GFP_KERNEL);

	pl08x = kzalloc(sizeof(*pl08x), GFP_KERNEL);

	if (!pl08x) {

		ret = -ENOMEM;

		goto out_no_pl08x;
@@ -1929,7 +1929,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id) 
	}



	/* Initialize physical channels */

	pl08x->phy_chans = kmalloc((vd->channels * sizeof(struct pl08x_phy_chan)),

	pl08x->phy_chans = kmalloc((vd->channels * sizeof(*pl08x->phy_chans)),

			GFP_KERNEL);

	if (!pl08x->phy_chans) {

		dev_err(&adev->dev, "%s failed to allocate "

CRA Git | Maintained and supported by SUSTech CRA and CCSE