Commit b1e3874c authored Oct 27, 2018 by Colin Ian King Committed by Herbert Xu Nov 09, 2018

pcrypt: use format specifier in kobject_add



Passing string 'name' as the format specifier is potentially hazardous
because name could (although very unlikely to) have a format specifier
embedded in it causing issues when parsing the non-existent arguments
to these.  Follow best practice by using the "%s" format string for
the string 'name'.

Cleans up clang warning:
crypto/pcrypt.c:397:40: warning: format string is not a string literal
(potentially insecure) [-Wformat-security]

Fixes: a3fb1e33 ("pcrypt: Added sysfs interface to pcrypt")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 7da66670

crypto/pcrypt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -394,7 +394,7 @@ static int pcrypt_sysfs_add(struct padata_instance pinst, const char name)
		int ret;

		pinst->kobj.kset = pcrypt_kset;
		ret = kobject_add(&pinst->kobj, NULL, name);
		ret = kobject_add(&pinst->kobj, NULL, "%s", name);
		if (!ret)
		kobject_uevent(&pinst->kobj, KOBJ_ADD);

Admin message