Commit b1d64c71 authored Aug 22, 2019 by Christophe JAILLET Committed by Linus Walleij Aug 23, 2019

gpio: ftgpio: Fix an error handling path in 'ftgpio_gpio_probe()'

If 'devm_kcalloc()' fails, we should go through the error handling path,
should some clean-up be needed.

Fixes: 42d9fc71 ("gpio: ftgpio: Pass irqchip when adding gpiochip")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20190822204538.4791-1-christophe.jaillet@wanadoo.fr

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent c7663fa2

drivers/gpio/gpio-ftgpio010.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -290,8 +290,10 @@ static int ftgpio_gpio_probe(struct platform_device *pdev)
		girq->num_parents = 1;
		girq->parents = devm_kcalloc(dev, 1, sizeof(*girq->parents),
		GFP_KERNEL);
		if (!girq->parents)
		return -ENOMEM;
		if (!girq->parents) {
		ret = -ENOMEM;
		goto dis_clk;
		}
		girq->default_type = IRQ_TYPE_NONE;
		girq->handler = handle_bad_irq;
		girq->parents[0] = irq;