Commit b1d21a24 authored Apr 15, 2016 by Stephen Boyd Committed by Mark Brown Apr 18, 2016

regulator: qcom_spmi: Always return a selector when asked



I had a thinko in spmi_regulator_select_voltage_same_range() when
converting it to return selectors via the function's return value
instead of by modifying a pointer argument. I only tested
multi-range regulators so this passed through testing. Fix it by
returning the selector here.

Fixes: 1b5b1968 ("regulator: qcom_spmi: Only use selector based regulator ops")
Reported-by: Rajendra Nayak <rnayak@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 1b5b1968

drivers/regulator/qcom_spmi-regulator.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -692,7 +692,7 @@ static int spmi_regulator_select_voltage_same_range(struct spmi_regulator *vreg,
		if (selector >= vreg->set_points->n_voltages)
		goto different_range;

		return 0;
		return selector;

		different_range:
		return spmi_regulator_select_voltage(vreg, min_uV, max_uV);

Admin message