Commit b1d16c49 authored May 20, 2009 by Christian Ehrhardt Committed by Avi Kivity Sep 10, 2009

KVM: s390: fix signal handling



If signal pending is true we exit without updating kvm_run, userspace
currently just does nothing and jumps to kvm_run again.
Since we did not set an exit_reason we might end up with a random one
(whatever was the last exit). Therefore it was possible to e.g. jump to
the psw position the last real interruption set.
Setting the INTR exit reason ensures that no old psw data is swapped
in on reentry.

Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

parent 9ace903d

arch/s390/kvm/kvm-s390.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -527,8 +527,10 @@ rerun_vcpu:
		if (rc == SIE_INTERCEPT_RERUNVCPU)
		goto rerun_vcpu;

		if (signal_pending(current) && !rc)
		if (signal_pending(current) && !rc) {
		kvm_run->exit_reason = KVM_EXIT_INTR;
		rc = -EINTR;
		}

		if (rc == -ENOTSUPP) {
		/* intercept cannot be handled in-kernel, prepare kvm-run */

Admin message