Commit b1c194dc authored Sep 17, 2020 by Vadym Kochan Committed by Greg Kroah-Hartman Sep 17, 2020

nvmem: core: fix missing of_node_put() in of_nvmem_device_get()



of_parse_phandle() returns device_node with incremented ref count
which needs to be decremented by of_node_put() when device_node
is not used.

Fixes: e2a5402e ("nvmem: Add nvmem_device based consumer apis.")
Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200917134437.16637-5-srinivas.kandagatla@linaro.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1eb51d6a

drivers/nvmem/core.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -835,6 +835,7 @@ struct nvmem_device of_nvmem_device_get(struct device_node np, const char *id)
		{

		struct device_node *nvmem_np;
		struct nvmem_device *nvmem;
		int index = 0;

		if (id)
		@@ -844,7 +845,9 @@ struct nvmem_device of_nvmem_device_get(struct device_node np, const char *id)
		if (!nvmem_np)
		return ERR_PTR(-ENOENT);

		return __nvmem_device_get(nvmem_np, device_match_of_node);
		nvmem = __nvmem_device_get(nvmem_np, device_match_of_node);
		of_node_put(nvmem_np);
		return nvmem;
		}
		EXPORT_SYMBOL_GPL(of_nvmem_device_get);
		#endif

Admin message