Commit b1c12cbc authored Apr 25, 2012 by Konstantin Khlebnikov Committed by Linus Torvalds Apr 25, 2012

mm/hugetlb: fix warning in alloc_huge_page/dequeue_huge_page_vma



Fix a gcc warning (and bug?) introduced in cc9a6c87 ("cpuset: mm: reduce
large amounts of memory barrier related damage v3")

Local variable "page" can be uninitialized if the nodemask from vma policy
does not intersects with nodemask from cpuset.  Even if it doesn't happens
it is better to initialize this variable explicitly than to introduce
a kernel oops in a weird corner case.

mm/hugetlb.c: In function `alloc_huge_page':
mm/hugetlb.c:1135:5: warning: `page' may be used uninitialized in this function

Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Acked-by: Mel Gorman <mgorman@suse.de>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 66f75a5d

mm/hugetlb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -532,7 +532,7 @@ static struct page dequeue_huge_page_vma(struct hstate h,
		struct vm_area_struct *vma,
		unsigned long address, int avoid_reserve)
		{
		struct page *page;
		struct page *page = NULL;
		struct mempolicy *mpol;
		nodemask_t *nodemask;
		struct zonelist *zonelist;

Admin message