Commit b1b135c8 authored by Christian Borntraeger's avatar Christian Borntraeger Committed by Rusty Russell
Browse files

fix spinlock recursion in hvc_console



commit 611e097d
Author: Christian Borntraeger <borntraeger@de.ibm.com>
hvc_console: rework setup to replace irq functions with callbacks
introduced a spinlock recursion problem.

request_irq tries to call the handler if the IRQ is shared.
The irq handler of hvc_console calls hvc_poll and hvc_kill
which might take the hvc_struct spinlock. Therefore, we have
to call request_irq outside the spinlock.

We can move the notifier_add safely outside the spinlock as ->data must
not be changed by the backend. Otherwise, tty_hangup would fail anyway.

Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent ed6d6876
Loading
Loading
Loading
Loading
+2 −3
Original line number Diff line number Diff line
@@ -322,11 +322,10 @@ static int hvc_open(struct tty_struct *tty, struct file * filp)

	hp->tty = tty;

	if (hp->ops->notifier_add)
		rc = hp->ops->notifier_add(hp, hp->data);

	spin_unlock_irqrestore(&hp->lock, flags);

	if (hp->ops->notifier_add)
		rc = hp->ops->notifier_add(hp, hp->data);

	/*
	 * If the notifier fails we return an error.  The tty layer