x86, pat: remove the dependency on 'vm_pgoff' in track/untrack pfn vma routines (b1a86e15) · Commits · 戴 / test

'pfn' argument for track_pfn_vma_new() can be used for reserving the attribute for the pfn range. No need to depend on 'vm_pgoff' Similarly, untrack_pfn_vma() can depend on the 'pfn' argument if it is non-zero or can use follow_phys() to get the starting value of the pfn range. Also the non zero 'size' argument can be used instead of recomputing it from vma. This cleanup also prepares the ground for the track/untrack pfn vma routines to take over the ownership of setting PAT specific vm_flag in the 'vma'. [khlebnikov@openvz.org: Clear pfn to paddr conversion] Signed-off-by:

Suresh Siddha <suresh.b.siddha@intel.com> Signed-off-by:

Konstantin Khlebnikov <khlebnikov@openvz.org> Cc: Venkatesh Pallipadi <venki@google.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Nick Piggin <npiggin@kernel.dk> Cc: Ingo Molnar <mingo@redhat.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: Carsten Otte <cotte@de.ibm.com> Cc: Chris Metcalf <cmetcalf@tilera.com> Cc: Cyrill Gorcunov <gorcunov@openvz.org> Cc: Eric Paris <eparis@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Hugh Dickins <hughd@google.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: James Morris <james.l.morris@oracle.com> Cc: Jason Baron <jbaron@redhat.com> Cc: Kentaro Takeda <takedakn@nttdata.co.jp> Cc: Matt Helsley <matthltc@us.ibm.com> Cc: Nick Piggin <npiggin@kernel.dk> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Robert Richter <robert.richter@amd.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Acked-by:

Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

arch/x86/mm/pat.c

+19 −14

Original line number	Diff line number	Diff line
		@@ -704,21 +704,18 @@ int track_pfn_vma_copy(struct vm_area_struct *vma)
		int track_pfn_vma_new(struct vm_area_struct vma, pgprot_t prot,
		unsigned long pfn, unsigned long size)
		{
		resource_size_t paddr = (resource_size_t)pfn << PAGE_SHIFT;
		unsigned long flags;
		resource_size_t paddr;
		unsigned long vma_size = vma->vm_end - vma->vm_start;

		if (is_linear_pfn_mapping(vma)) {
		/* reserve the whole chunk starting from vm_pgoff */
		paddr = (resource_size_t)vma->vm_pgoff << PAGE_SHIFT;
		return reserve_pfn_range(paddr, vma_size, prot, 0);
		}
		/* reserve the whole chunk starting from paddr */
		if (is_linear_pfn_mapping(vma))
		return reserve_pfn_range(paddr, size, prot, 0);

		if (!pat_enabled)
		return 0;

		/* for vm_insert_pfn and friends, we set prot based on lookup */
		flags = lookup_memtype(pfn << PAGE_SHIFT);
		flags = lookup_memtype(paddr);
		*prot = __pgprot((pgprot_val(vma->vm_page_prot) & (~_PAGE_CACHE_MASK)) \|
		flags);

		@@ -728,20 +725,28 @@ int track_pfn_vma_new(struct vm_area_struct vma, pgprot_t prot,
		/*
		* untrack_pfn_vma is called while unmapping a pfnmap for a region.
		* untrack can be called for a specific region indicated by pfn and size or
		* can be for the entire vma (in which case size can be zero).
		* can be for the entire vma (in which case pfn, size are zero).
		*/
		void untrack_pfn_vma(struct vm_area_struct *vma, unsigned long pfn,
		unsigned long size)
		{
		resource_size_t paddr;
		unsigned long vma_size = vma->vm_end - vma->vm_start;
		unsigned long prot;

		if (is_linear_pfn_mapping(vma)) {
		/* free the whole chunk starting from vm_pgoff */
		paddr = (resource_size_t)vma->vm_pgoff << PAGE_SHIFT;
		free_pfn_range(paddr, vma_size);
		if (!is_linear_pfn_mapping(vma))
		return;

		/* free the chunk starting from pfn or the whole chunk */
		paddr = (resource_size_t)pfn << PAGE_SHIFT;
		if (!paddr && !size) {
		if (follow_phys(vma, vma->vm_start, 0, &prot, &paddr)) {
		WARN_ON_ONCE(1);
		return;
		}

		size = vma->vm_end - vma->vm_start;
		}
		free_pfn_range(paddr, size);
		}

		pgprot_t pgprot_writecombine(pgprot_t prot)

Admin message