Commit b1983cd8 authored May 04, 2013 by Al Viro

create_mnt_ns: unidiomatic use of list_add()



while list_add(A, B) and list_add(B, A) are equivalent when both A and B
are guaranteed to be empty, the usual idiom is list_add(what, where),
not the other way round...  Not a bug per se, but only by accident and
it makes RTFS harder for no good reason.

Spotted-by: Rajat Sharma <fs.rajat@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 61572bb1

fs/namespace.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2463,7 +2463,7 @@ static struct mnt_namespace create_mnt_ns(struct vfsmount m)
		struct mount *mnt = real_mount(m);
		mnt->mnt_ns = new_ns;
		new_ns->root = mnt;
		list_add(&new_ns->list, &mnt->mnt_list);
		list_add(&mnt->mnt_list, &new_ns->list);
		} else {
		mntput(m);
		}

Admin message