Commit b14a3904 authored Oct 10, 2019 by Johan Hovold Committed by Greg Kroah-Hartman Oct 15, 2019

USB: ldusb: fix memleak on disconnect



If disconnect() races with release() after a process has been
interrupted, release() could end up returning early and the driver would
fail to free its driver data.

Fixes: 2824bd25 ("[PATCH] USB: add ldusb driver")
Cc: stable <stable@vger.kernel.org>     # 2.6.13
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191010125835.27031-2-johan@kernel.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4f5cafb5

drivers/usb/misc/ldusb.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -380,10 +380,7 @@ static int ld_usb_release(struct inode inode, struct file file)
		goto exit;
		}

		if (mutex_lock_interruptible(&dev->mutex)) {
		retval = -ERESTARTSYS;
		goto exit;
		}
		mutex_lock(&dev->mutex);

		if (dev->open_count != 1) {
		retval = -ENODEV;

Admin message