Commit b135fc08 authored Feb 16, 2020 by Amol Grover Committed by Pablo Neira Ayuso Apr 06, 2020

netfilter: ipset: Pass lockdep expression to RCU lists



ip_set_type_list is traversed using list_for_each_entry_rcu
outside an RCU read-side critical section but under the protection
of ip_set_type_mutex.

Hence, add corresponding lockdep expression to silence false-positive
warnings, and harden RCU lists.

Signed-off-by: Amol Grover <frextrite@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 7fb6f78d

net/netfilter/ipset/ip_set_core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -86,7 +86,8 @@ find_set_type(const char *name, u8 family, u8 revision)
		{
		struct ip_set_type *type;

		list_for_each_entry_rcu(type, &ip_set_type_list, list)
		list_for_each_entry_rcu(type, &ip_set_type_list, list,
		lockdep_is_held(&ip_set_type_mutex))
		if (STRNCMP(type->name, name) &&
		(type->family == family \|\|
		type->family == NFPROTO_UNSPEC) &&

Admin message