Commit b1286ed7 authored Nov 30, 2018 by Linus Torvalds

test_hexdump: use memcpy instead of strncpy



New versions of gcc reasonably warn about the odd pattern of

	strncpy(p, q, strlen(q));

which really doesn't make sense: the strncpy() ends up being just a slow
and odd way to write memcpy() in this case.

Apparently there was a patch for this floating around earlier, but it
got lost.

Acked-again-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 1ec63573

lib/test_hexdump.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -99,7 +99,7 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize,
		const char q = result++;
		size_t amount = strlen(q);

		strncpy(p, q, amount);
		memcpy(p, q, amount);
		p += amount;

		*p++ = ' ';

Admin message