Commit b1214e47 authored Nov 12, 2013 by Xue jiufei Committed by Linus Torvalds Nov 13, 2013

ocfs2: fix possible double free in ocfs2_write_begin_nolock



When ocfs2_write_cluster_by_desc() failed in ocfs2_write_begin_nolock()
because of ENOSPC, it goes to out_quota, freeing data_ac(meta_ac).  Then
it calls ocfs2_try_to_free_truncate_log() to free space.  If enough
space freed, it will try to write again.  Unfortunately, some error
happenes before ocfs2_lock_allocators(), it goes to out and free
data_ac(meta_ac) again.

Signed-off-by: joyce <xuejiufei@huawei.com>
Reviewed-by: Jie Liu <jeff.liu@oracle.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent bfbca926

fs/ocfs2/aops.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -1898,10 +1898,14 @@ out_commit:
		out:
		ocfs2_free_write_ctxt(wc);

		if (data_ac)
		if (data_ac) {
		ocfs2_free_alloc_context(data_ac);
		if (meta_ac)
		data_ac = NULL;
		}
		if (meta_ac) {
		ocfs2_free_alloc_context(meta_ac);
		meta_ac = NULL;
		}

		if (ret == -ENOSPC && try_free) {
		/*

Admin message