Commit b11f75d0 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

mfd: ab8500: no need to check return value of debugfs_create functions 

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20190706164722.18766-2-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 45640a38

drivers/mfd/ab8500-debugfs.c

+98 −226
Original line number Diff line number Diff line
@@ -2644,12 +2644,10 @@ static const struct file_operations ab8500_hwreg_fops = { 
	.owner = THIS_MODULE,

};



static struct dentry *ab8500_dir;

static struct dentry *ab8500_gpadc_dir;



static int ab8500_debug_probe(struct platform_device *plf)

{

	struct dentry *file;

	struct dentry *ab8500_dir;

	struct dentry *ab8500_gpadc_dir;

	struct ab8500 *ab8500;

	struct resource *res;
@@ -2694,47 +2692,22 @@ static int ab8500_debug_probe(struct platform_device *plf) 
	}



	ab8500_dir = debugfs_create_dir(AB8500_NAME_STRING, NULL);

	if (!ab8500_dir)

		goto err;



	ab8500_gpadc_dir = debugfs_create_dir(AB8500_ADC_NAME_STRING,

					      ab8500_dir);

	if (!ab8500_gpadc_dir)

		goto err;



	file = debugfs_create_file("all-bank-registers", S_IRUGO, ab8500_dir,

	debugfs_create_file("all-bank-registers", S_IRUGO, ab8500_dir,

			    &plf->dev, &ab8500_bank_registers_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("all-banks", S_IRUGO, ab8500_dir,

	debugfs_create_file("all-banks", S_IRUGO, ab8500_dir,

			    &plf->dev, &ab8500_all_banks_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("register-bank",

				   (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("register-bank", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_dir, &plf->dev, &ab8500_bank_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("register-address",

				   (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("register-address", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_dir, &plf->dev, &ab8500_address_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("register-value",

				   (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("register-value", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_dir, &plf->dev, &ab8500_val_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("irq-subscribe",

				   (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir,

				   &plf->dev, &ab8500_subscribe_fops);

	if (!file)

		goto err;

	debugfs_create_file("irq-subscribe", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_dir, &plf->dev, &ab8500_subscribe_fops);



	if (is_ab8500(ab8500)) {

		debug_ranges = ab8500_debug_ranges;
@@ -2750,194 +2723,93 @@ static int ab8500_debug_probe(struct platform_device *plf) 
		num_interrupt_lines = AB8540_NR_IRQS;

	}



	file = debugfs_create_file("interrupts", (S_IRUGO), ab8500_dir,

				   &plf->dev, &ab8500_interrupts_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("irq-unsubscribe",

				   (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir,

				   &plf->dev, &ab8500_unsubscribe_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("hwreg", (S_IRUGO | S_IWUSR | S_IWGRP),

				   ab8500_dir, &plf->dev, &ab8500_hwreg_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("all-modem-registers",

				   (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("interrupts", (S_IRUGO), ab8500_dir, &plf->dev,

			    &ab8500_interrupts_fops);

	debugfs_create_file("irq-unsubscribe", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_dir, &plf->dev, &ab8500_unsubscribe_fops);

	debugfs_create_file("hwreg", (S_IRUGO | S_IWUSR | S_IWGRP), ab8500_dir,

			    &plf->dev, &ab8500_hwreg_fops);

	debugfs_create_file("all-modem-registers", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_dir, &plf->dev, &ab8500_modem_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("bat_ctrl", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("bat_ctrl", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_bat_ctrl_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("btemp_ball", (S_IRUGO | S_IWUSR | S_IWGRP),

				   ab8500_gpadc_dir,

				   &plf->dev, &ab8500_gpadc_btemp_ball_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("main_charger_v",

				   (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("btemp_ball", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_btemp_ball_fops);

	debugfs_create_file("main_charger_v", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_main_charger_v_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("acc_detect1",

				   (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("acc_detect1", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_acc_detect1_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("acc_detect2",

				   (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("acc_detect2", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_acc_detect2_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("adc_aux1", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("adc_aux1", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_aux1_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("adc_aux2", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("adc_aux2", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_aux2_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("main_bat_v", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("main_bat_v", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_main_bat_v_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("vbus_v", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("vbus_v", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_vbus_v_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("main_charger_c",

				   (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("main_charger_c", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_main_charger_c_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("usb_charger_c",

				   (S_IRUGO | S_IWUSR | S_IWGRP),

				   ab8500_gpadc_dir,

				   &plf->dev, &ab8500_gpadc_usb_charger_c_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("bk_bat_v", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("usb_charger_c", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_usb_charger_c_fops);

	debugfs_create_file("bk_bat_v", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_bk_bat_v_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("die_temp", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("die_temp", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_die_temp_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("usb_id", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("usb_id", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_usb_id_fops);

	if (!file)

		goto err;



	if (is_ab8540(ab8500)) {

		file = debugfs_create_file("xtal_temp",

					   (S_IRUGO | S_IWUSR | S_IWGRP),

		debugfs_create_file("xtal_temp", (S_IRUGO | S_IWUSR | S_IWGRP),

				    ab8500_gpadc_dir, &plf->dev,

				    &ab8540_gpadc_xtal_temp_fops);

		if (!file)

			goto err;

		file = debugfs_create_file("vbattruemeas",

					   (S_IRUGO | S_IWUSR | S_IWGRP),

		debugfs_create_file("vbattruemeas", (S_IRUGO | S_IWUSR | S_IWGRP),

				    ab8500_gpadc_dir, &plf->dev,

				    &ab8540_gpadc_vbat_true_meas_fops);

		if (!file)

			goto err;

		file = debugfs_create_file("batctrl_and_ibat",

					(S_IRUGO | S_IWUGO),

					ab8500_gpadc_dir,

					&plf->dev,

		debugfs_create_file("batctrl_and_ibat", (S_IRUGO | S_IWUGO),

				    ab8500_gpadc_dir, &plf->dev,

				    &ab8540_gpadc_bat_ctrl_and_ibat_fops);

		if (!file)

			goto err;

		file = debugfs_create_file("vbatmeas_and_ibat",

					(S_IRUGO | S_IWUGO),

		debugfs_create_file("vbatmeas_and_ibat", (S_IRUGO | S_IWUGO),

				    ab8500_gpadc_dir, &plf->dev,

				    &ab8540_gpadc_vbat_meas_and_ibat_fops);

		if (!file)

			goto err;

		file = debugfs_create_file("vbattruemeas_and_ibat",

				(S_IRUGO | S_IWUGO),

				ab8500_gpadc_dir,

				&plf->dev,

		debugfs_create_file("vbattruemeas_and_ibat", (S_IRUGO | S_IWUGO),

				    ab8500_gpadc_dir, &plf->dev,

				    &ab8540_gpadc_vbat_true_meas_and_ibat_fops);

		if (!file)

			goto err;

		file = debugfs_create_file("battemp_and_ibat",

			(S_IRUGO | S_IWUGO),

			ab8500_gpadc_dir,

			&plf->dev, &ab8540_gpadc_bat_temp_and_ibat_fops);

		if (!file)

			goto err;

		file = debugfs_create_file("otp_calib",

				(S_IRUGO | S_IWUSR | S_IWGRP),

				ab8500_gpadc_dir,

				&plf->dev, &ab8540_gpadc_otp_calib_fops);

		if (!file)

			goto err;

	}

	file = debugfs_create_file("avg_sample", (S_IRUGO | S_IWUSR | S_IWGRP),

		debugfs_create_file("battemp_and_ibat", (S_IRUGO | S_IWUGO),

				    ab8500_gpadc_dir, &plf->dev,

				    &ab8540_gpadc_bat_temp_and_ibat_fops);

		debugfs_create_file("otp_calib", (S_IRUGO | S_IWUSR | S_IWGRP),

				    ab8500_gpadc_dir, &plf->dev,

				    &ab8540_gpadc_otp_calib_fops);

	}

	debugfs_create_file("avg_sample", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_avg_sample_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("trig_edge", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("trig_edge", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_trig_edge_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("trig_timer", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("trig_timer", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_trig_timer_fops);

	if (!file)

		goto err;



	file = debugfs_create_file("conv_type", (S_IRUGO | S_IWUSR | S_IWGRP),

	debugfs_create_file("conv_type", (S_IRUGO | S_IWUSR | S_IWGRP),

			    ab8500_gpadc_dir, &plf->dev,

			    &ab8500_gpadc_conv_type_fops);

	if (!file)

		goto err;



	return 0;



err:

	debugfs_remove_recursive(ab8500_dir);

	dev_err(&plf->dev, "failed to create debugfs entries.\n");



	return -ENOMEM;

}



static struct platform_driver ab8500_debug_driver = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE