Commit b0efcae5 authored by Jacob Keller's avatar Jacob Keller Committed by David S. Miller
Browse files

devlink: correct misspelling of snapshot 



The function to obtain a unique snapshot id was mistakenly typo'd as
devlink_region_shapshot_id_get. Fix this typo by renaming the function
and all of its users.

Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a5c3a7c0

drivers/net/ethernet/mellanox/mlx4/crdump.c

+1 −1
Original line number Diff line number Diff line
@@ -182,7 +182,7 @@ int mlx4_crdump_collect(struct mlx4_dev *dev) 
	crdump_enable_crspace_access(dev, cr_space);



	/* Get the available snapshot ID for the dumps */

	id = devlink_region_shapshot_id_get(devlink);

	id = devlink_region_snapshot_id_get(devlink);



	/* Try to capture dumps */

	mlx4_crdump_collect_crspace(dev, cr_space, id);

drivers/net/netdevsim/dev.c

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ static ssize_t nsim_dev_take_snapshot_write(struct file *file, 


	get_random_bytes(dummy_data, NSIM_DEV_DUMMY_REGION_SIZE);



	id = devlink_region_shapshot_id_get(priv_to_devlink(nsim_dev));

	id = devlink_region_snapshot_id_get(priv_to_devlink(nsim_dev));

	err = devlink_region_snapshot_create(nsim_dev->dummy_region,

					     dummy_data, id, kfree);

	if (err) {

include/net/devlink.h

+1 −1
Original line number Diff line number Diff line
@@ -938,7 +938,7 @@ struct devlink_region *devlink_region_create(struct devlink *devlink, 
					     u32 region_max_snapshots,

					     u64 region_size);

void devlink_region_destroy(struct devlink_region *region);

u32 devlink_region_shapshot_id_get(struct devlink *devlink);

u32 devlink_region_snapshot_id_get(struct devlink *devlink);

int devlink_region_snapshot_create(struct devlink_region *region,

				   u8 *data, u32 snapshot_id,

				   devlink_snapshot_data_dest_t *data_destructor);

net/core/devlink.c

+3 −3
Original line number Diff line number Diff line
@@ -7563,7 +7563,7 @@ void devlink_region_destroy(struct devlink_region *region) 
EXPORT_SYMBOL_GPL(devlink_region_destroy);



/**

 *	devlink_region_shapshot_id_get - get snapshot ID

 *	devlink_region_snapshot_id_get - get snapshot ID

 *

 *	This callback should be called when adding a new snapshot,

 *	Driver should use the same id for multiple snapshots taken
@@ -7571,7 +7571,7 @@ EXPORT_SYMBOL_GPL(devlink_region_destroy); 
 *

 *	@devlink: devlink

 */

u32 devlink_region_shapshot_id_get(struct devlink *devlink)

u32 devlink_region_snapshot_id_get(struct devlink *devlink)

{

	u32 id;
@@ -7581,7 +7581,7 @@ u32 devlink_region_shapshot_id_get(struct devlink *devlink) 


	return id;

}

EXPORT_SYMBOL_GPL(devlink_region_shapshot_id_get);

EXPORT_SYMBOL_GPL(devlink_region_snapshot_id_get);



/**

 *	devlink_region_snapshot_create - create a new snapshot

CRA Git | Maintained and supported by SUSTech CRA and CCSE