Commit b0e370b9 authored Jun 11, 2019 by Wolfram Sang Committed by Ulf Hansson Jun 17, 2019

mmc: core: complete HS400 before checking status

We don't have a reproducible error case, yet our BSP team suggested that
the mmc_switch_status() command in mmc_select_hs400() should come after
the callback into the driver completing HS400 setup. It makes sense to
me because we want the status of a fully setup HS400, so it will
increase the reliability of the mmc_switch_status() command.

Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Fixes: ba6c7ac3 ("mmc: core: more fine-grained hooks for HS400 tuning")
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 97bf85b6

drivers/mmc/core/mmc.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1212,13 +1212,13 @@ static int mmc_select_hs400(struct mmc_card *card)
		mmc_set_timing(host, MMC_TIMING_MMC_HS400);
		mmc_set_bus_speed(card);

		if (host->ops->hs400_complete)
		host->ops->hs400_complete(host);

		err = mmc_switch_status(card);
		if (err)
		goto out_err;

		if (host->ops->hs400_complete)
		host->ops->hs400_complete(host);

		return 0;

		out_err:

Admin message