Unverified Commit b0ce7b29 authored by Linus Walleij's avatar Linus Walleij Committed by Mark Brown
Browse files

regulator/gpio: Allow nonexclusive GPIO access 



This allows nonexclusive (simultaneous) access to a single
GPIO line for the fixed regulator enable line. This happens
when several regulators use the same GPIO for enabling and
disabling a regulator, and all need a handle on their GPIO
descriptor.

This solution with a special flag is not entirely elegant
and should ideally be replaced by something more careful as
this makes it possible for several consumers to
enable/disable the same GPIO line to the left and right
without any consistency. The current use inside the regulator
core should however be fine as it takes special care to
handle this.

For the state of the GPIO backend, this is still the
lesser evil compared to going back to global GPIO
numbers.

Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Fixes: efdfeb07 ("regulator: fixed: Convert to use GPIO descriptor only")
Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Tested-by: default avatarJon Hunter <jonathanh@nvidia.com>
Tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bef9391c

drivers/gpio/gpiolib.c

+17 −2
Original line number Diff line number Diff line
@@ -3908,8 +3908,23 @@ struct gpio_desc *__must_check gpiod_get_index(struct device *dev, 
	 * the device name as label

	 */

	status = gpiod_request(desc, con_id ? con_id : devname);

	if (status < 0)

	if (status < 0) {

		if (status == -EBUSY && flags & GPIOD_FLAGS_BIT_NONEXCLUSIVE) {

			/*

			 * This happens when there are several consumers for

			 * the same GPIO line: we just return here without

			 * further initialization. It is a bit if a hack.

			 * This is necessary to support fixed regulators.

			 *

			 * FIXME: Make this more sane and safe.

			 */

			dev_info(dev, "nonexclusive access to GPIO for %s\n",

				 con_id ? con_id : devname);

			return desc;

		} else {

			return ERR_PTR(status);

		}

	}



	status = gpiod_configure_flags(desc, con_id, lookupflags, flags);

	if (status < 0) {

drivers/regulator/fixed.c

+13 −0
Original line number Diff line number Diff line
@@ -170,6 +170,19 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev) 
			gflags = GPIOD_OUT_LOW_OPEN_DRAIN;

	}



	/*

	 * Some fixed regulators share the enable line between two

	 * regulators which makes it necessary to get a handle on the

	 * same descriptor for two different consumers. This will get

	 * the GPIO descriptor, but only the first call will initialize

	 * it so any flags such as inversion or open drain will only

	 * be set up by the first caller and assumed identical on the

	 * next caller.

	 *

	 * FIXME: find a better way to deal with this.

	 */

	gflags |= GPIOD_FLAGS_BIT_NONEXCLUSIVE;



	cfg.ena_gpiod = devm_gpiod_get_optional(&pdev->dev, NULL, gflags);

	if (IS_ERR(cfg.ena_gpiod))

		return PTR_ERR(cfg.ena_gpiod);

include/linux/gpio/consumer.h

+1 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ struct gpio_descs { 
#define GPIOD_FLAGS_BIT_DIR_OUT		BIT(1)

#define GPIOD_FLAGS_BIT_DIR_VAL		BIT(2)

#define GPIOD_FLAGS_BIT_OPEN_DRAIN	BIT(3)

#define GPIOD_FLAGS_BIT_NONEXCLUSIVE	BIT(4)



/**

 * Optional flags that can be passed to one of gpiod_* to configure direction

CRA Git | Maintained and supported by SUSTech CRA and CCSE