Commit b0c03eff authored by Matheus Castello's avatar Matheus Castello Committed by Wei Liu
Browse files

drivers: hv: vmbus: Fix checkpatch SPLIT_STRING 



Checkpatch emits WARNING: quoted string split across lines.
To keep the code clean and with the 80 column length indentation the
check and registration code for kmsg_dump_register has been transferred
to a new function hv_kmsg_dump_register.

Signed-off-by: default avatarMatheus Castello <matheus@castello.eng.br>
Reviewed-by: default avatarMichael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20201125032926.17002-1-matheus@castello.eng.br


Signed-off-by: default avatarWei Liu <wei.liu@kernel.org>
parent 206ad34d

drivers/hv/vmbus_drv.c

+20 −15
Original line number Diff line number Diff line
@@ -1387,6 +1387,24 @@ static struct kmsg_dumper hv_kmsg_dumper = { 
	.dump = hv_kmsg_dump,

};



static void hv_kmsg_dump_register(void)

{

	int ret;



	hv_panic_page = hv_alloc_hyperv_zeroed_page();

	if (!hv_panic_page) {

		pr_err("Hyper-V: panic message page memory allocation failed\n");

		return;

	}



	ret = kmsg_dump_register(&hv_kmsg_dumper);

	if (ret) {

		pr_err("Hyper-V: kmsg dump register error 0x%x\n", ret);

		hv_free_hyperv_page((unsigned long)hv_panic_page);

		hv_panic_page = NULL;

	}

}



static struct ctl_table_header *hv_ctl_table_hdr;



/*
@@ -1477,21 +1495,8 @@ static int vmbus_bus_init(void) 
		 * capability is supported by the hypervisor.

		 */

		hv_get_crash_ctl(hyperv_crash_ctl);

		if (hyperv_crash_ctl & HV_CRASH_CTL_CRASH_NOTIFY_MSG) {

			hv_panic_page = (void *)hv_alloc_hyperv_zeroed_page();

			if (hv_panic_page) {

				ret = kmsg_dump_register(&hv_kmsg_dumper);

				if (ret) {

					pr_err("Hyper-V: kmsg dump register "

						"error 0x%x\n", ret);

					hv_free_hyperv_page(

					    (unsigned long)hv_panic_page);

					hv_panic_page = NULL;

				}

			} else

				pr_err("Hyper-V: panic message page memory "

					"allocation failed");

		}

		if (hyperv_crash_ctl & HV_CRASH_CTL_CRASH_NOTIFY_MSG)

			hv_kmsg_dump_register();



		register_die_notifier(&hyperv_die_block);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE