Commit b0a465d8 authored by Sarah Sharp's avatar Sarah Sharp
Browse files

xhci: Remove debugging about toggling cycle bits. 



The code for toggling the cycle bits when the ring wraps around has
worked for years.  The print statement alone is not enough to indicate
there's something wrong with that code.  Now that full transfer tracing
has been ripped out, the print statement or lack thereof won't help
without context of where the enqueue pointer is.

Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
parent 3d616f5a

drivers/usb/host/xhci-ring.c

+0 −13
Original line number Diff line number Diff line
@@ -155,10 +155,6 @@ static void inc_deq(struct xhci_hcd *xhci, struct xhci_ring *ring, bool consumer 
	while (last_trb(xhci, ring, ring->deq_seg, next)) {

		if (consumer && last_trb_on_last_seg(xhci, ring, ring->deq_seg, next)) {

			ring->cycle_state = (ring->cycle_state ? 0 : 1);

			if (!in_interrupt())

				xhci_dbg(xhci, "Toggle cycle state for ring %p = %i\n",

						ring,

						(unsigned int) ring->cycle_state);

		}

		ring->deq_seg = ring->deq_seg->next;

		ring->dequeue = ring->deq_seg->trbs;
@@ -231,10 +227,6 @@ static void inc_enq(struct xhci_hcd *xhci, struct xhci_ring *ring, 
			/* Toggle the cycle bit after the last ring segment. */

			if (last_trb_on_last_seg(xhci, ring, ring->enq_seg, next)) {

				ring->cycle_state = (ring->cycle_state ? 0 : 1);

				if (!in_interrupt())

					xhci_dbg(xhci, "Toggle cycle state for ring %p = %i\n",

							ring,

							(unsigned int) ring->cycle_state);

			}

		}

		ring->enq_seg = ring->enq_seg->next;
@@ -2476,11 +2468,6 @@ static int prepare_ring(struct xhci_hcd *xhci, struct xhci_ring *ep_ring, 
			/* Toggle the cycle bit after the last ring segment. */

			if (last_trb_on_last_seg(xhci, ring, ring->enq_seg, next)) {

				ring->cycle_state = (ring->cycle_state ? 0 : 1);

				if (!in_interrupt()) {

					xhci_dbg(xhci, "queue_trb: Toggle cycle "

						"state for ring %p = %i\n",

						ring, (unsigned int)ring->cycle_state);

				}

			}

			ring->enq_seg = ring->enq_seg->next;

			ring->enqueue = ring->enq_seg->trbs;

CRA Git | Maintained and supported by SUSTech CRA and CCSE