Commit b09d2501 authored Apr 01, 2009 by H. Peter Anvin Committed by Ingo Molnar Apr 06, 2009

mutex: drop "inline" from mutex_lock() inside kernel/mutex.c



Impact: build fix

mutex_lock() is was defined inline in kernel/mutex.c, but wasn't
declared so not in <linux/mutex.h>.  This didn't cause a problem until
checkin 3a2d367d9aabac486ac4444c6c7ec7a1dab16267 added the
atomic_dec_and_mutex_lock() inline in between declaration and
definion.

This broke building with CONFIG_ALLOW_WARNINGS=n, e.g. make
allnoconfig.

Either from the source code nor the allnoconfig binary output I cannot
find any internal references to mutex_lock() in kernel/mutex.c, so
presumably this "inline" is now-useless legacy.

Cc: Eric Paris <eparis@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Orig-LKML-Reference: <tip-3a2d367d9aabac486ac4444c6c7ec7a1dab16267@git.kernel.org>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

parent 9ab772cd

kernel/mutex.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -89,7 +89,7 @@ __mutex_lock_slowpath(atomic_t *lock_count);
		*
		* This function is similar to (but not equivalent to) down().
		*/
		void inline __sched mutex_lock(struct mutex *lock)
		void __sched mutex_lock(struct mutex *lock)
		{
		might_sleep();
		/*

Admin message