Commit b091f7fe authored Jun 16, 2020 by Waiman Long Committed by David Sterba Jun 16, 2020

btrfs: use kfree() in btrfs_ioctl_get_subvol_info()



In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc()
was incorrectly paired with kzfree(). According to David Sterba, there
isn't any sensitive information in the subvol_info that needs to be
cleared before freeing. So kzfree() isn't really needed, use kfree()
instead.

Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 5dbb75ed

fs/btrfs/ioctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2692,7 +2692,7 @@ out:
		btrfs_put_root(root);
		out_free:
		btrfs_free_path(path);
		kzfree(subvol_info);
		kfree(subvol_info);
		return ret;
		}

Admin message