Commit b0918612 authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt
Browse files

ktest: Add CONFIG_BISECT_CHECK option 



The config-bisect can take a bad config and bisect it down to find out
what config actually breaks the config. But as all tests will apply a
minconfig (defined by a user) to apply before booting, it is possible
that the minconfig could actually make the bad config work (minconfigs
can disable configs). The end result is that the config bisect test will
not find a config that breaks. This can be rather frustrating to the
user.

The CONFIG_BISECT_CHECK option, when set to 1, will make sure that the
bad config (with the minconfig applied) still fails before trying to
bisect.

And yes, I did get burned by this.

Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent e5c2ec11

tools/testing/ktest/ktest.pl

+14 −0
Original line number Diff line number Diff line
@@ -173,6 +173,7 @@ my $bisect_check; 


my $config_bisect;

my $config_bisect_type;

my $config_bisect_check;



my $patchcheck_type;

my $patchcheck_start;
@@ -283,6 +284,7 @@ my %option_map = ( 


    "CONFIG_BISECT"		=> \$config_bisect,

    "CONFIG_BISECT_TYPE"	=> \$config_bisect_type,

    "CONFIG_BISECT_CHECK"	=> \$config_bisect_check,



    "PATCHCHECK_TYPE"		=> \$patchcheck_type,

    "PATCHCHECK_START"		=> \$patchcheck_start,
@@ -2743,6 +2745,18 @@ sub config_bisect { 
	}

    }

    my $ret;



    if (defined($config_bisect_check) && $config_bisect_check) {

	doprint " Checking to make sure bad config with min config fails\n";

	create_config keys %config_list;

	$ret = run_config_bisect_test $config_bisect_type;

	if ($ret) {

	    doprint " FAILED! Bad config with min config boots fine\n";

	    return -1;

	}

	doprint " Bad config with min config fails as expected\n";

    }



    do {

	$ret = run_config_bisect;

    } while (!$ret);

tools/testing/ktest/sample.conf

+6 −0
Original line number Diff line number Diff line
@@ -1077,6 +1077,12 @@ 
#  can specify it with CONFIG_BISECT_GOOD. Otherwise

#  the MIN_CONFIG is the base.

#

# CONFIG_BISECT_CHECK (optional)

#  Set this to 1 if you want to confirm that the config ktest

#  generates (the bad config with the min config) is still bad.

#  It may be that the min config fixes what broke the bad config

#  and the test will not return a result.

#

# Example:

#   TEST_START

#   TEST_TYPE = config_bisect

CRA Git | Maintained and supported by SUSTech CRA and CCSE