Commit b081808a authored Jan 28, 2018 by Leon Romanovsky Committed by Jason Gunthorpe Jan 28, 2018

RDMA/mlx5: Avoid memory leak in case of XRCD dealloc failure



Failure in XRCD FW deallocation command leaves memory leaked and
returns error to the user which he can't do anything about it.

This patch changes behavior to always free memory and always return
success to the user.

Fixes: e126ba97 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Reviewed-by: Majd Dibbiny <majd@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent f23a5350

drivers/infiniband/hw/mlx5/qp.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -5067,13 +5067,10 @@ int mlx5_ib_dealloc_xrcd(struct ib_xrcd *xrcd)
		int err;

		err = mlx5_core_xrcd_dealloc(dev->mdev, xrcdn);
		if (err) {
		if (err)
		mlx5_ib_warn(dev, "failed to dealloc xrcdn 0x%x\n", xrcdn);
		return err;
		}

		kfree(xrcd);

		return 0;
		}

Admin message