Commit b0816f88 authored Nov 28, 2019 by Rasmus Villemoes Committed by Li Yang Dec 09, 2019

serial: ucc_uart: limit brg-frequency workaround to PPC32



According to Timur Tabi

    This bug in older U-Boots is definitely PowerPC-specific

So before allowing this driver to be built for platforms other than
PPC32, make sure that we don't accept malformed device trees on those
other platforms.

Suggested-by: Timur Tabi <timur@kernel.org>
Reviewed-by: Timur Tabi <timur@kernel.org>
Acked-by: Timur Tabi <timur@kernel.org>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Li Yang <leoyang.li@nxp.com>

parent 89ad26f5

drivers/tty/serial/ucc_uart.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1392,6 +1392,13 @@ static int ucc_uart_probe(struct platform_device *ofdev)
		if (val)
		qe_port->port.uartclk = val;
		else {
		if (!IS_ENABLED(CONFIG_PPC32)) {
		dev_err(&ofdev->dev,
		"invalid brg-frequency in device tree\n");
		ret = -EINVAL;
		goto out_np;
		}

		/*
		* Older versions of U-Boot do not initialize the brg-frequency
		* property, so in this case we assume the BRG frequency is

Admin message