Commit b079bd55 authored Jul 04, 2016 by Peter Chen Committed by Sudeep Holla Aug 08, 2016

firmware: arm_scpi: add missing of_node_put after calling of_parse_phandle



of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using it.

Besides, of_address_to_resource always returns -EINVAL for error, delete
the assignment for ret.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

parent 557e37c0

drivers/firmware/arm_scpi.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -709,9 +709,10 @@ static int scpi_probe(struct platform_device *pdev)
		struct mbox_client *cl = &pchan->cl;
		struct device_node *shmem = of_parse_phandle(np, "shmem", idx);

		if (of_address_to_resource(shmem, 0, &res)) {
		ret = of_address_to_resource(shmem, 0, &res);
		of_node_put(shmem);
		if (ret) {
		dev_err(dev, "failed to get SCPI payload mem resource\n");
		ret = -EINVAL;
		goto err;
		}

Admin message