Commit b071126b authored Dec 13, 2019 by Dmitry Safonov Committed by Greg Kroah-Hartman Dec 18, 2019

tty/serial: Migrate sunhv to use has_sysrq



The SUPPORT_SYSRQ ifdeffery is not nice as:
- May create misunderstanding about sizeof(struct uart_port) between
  different objects
- Prevents moving functions from serial_core.h
- Reduces readability (well, it's ifdeffery - it's hard to follow)

In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added.
Initialise it in driver's probe and remove ifdeffery.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Signed-off-by: Dmitry Safonov <dima@arista.com>
Link: https://lore.kernel.org/r/20191213000657.931618-46-dima@arista.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9feedaa7

drivers/tty/serial/sunhv.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -25,10 +25,6 @@
		#include <asm/irq.h>
		#include <asm/setup.h>

		#if defined(CONFIG_MAGIC_SYSRQ)
		#define SUPPORT_SYSRQ
		#endif

		#include <linux/serial_core.h>
		#include <linux/sunserialcore.h>

		@@ -552,6 +548,7 @@ static int hv_probe(struct platform_device *op)

		sunhv_port = port;

		port->has_sysrq = 1;
		port->line = 0;
		port->ops = &sunhv_pops;
		port->type = PORT_SUNHV;

Admin message