ksz884x: remove unnecessary setting of skb->dev (b06b66c0) · Commits · 戴 / test

skb->dev is being unnecessarily set during ring init. It is already being set to the proper value when eth_type_trans is called on packet receive, and the skb->dev is not referenced anywhere else in the code. Signed-off-by:

Jon Mason <jdmason@kudzu.us> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/micrel/ksz884x.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -4480,14 +4480,12 @@ static void ksz_init_rx_buffers(struct dev_info *adapter)
		dma_buf->len = adapter->mtu;
		if (!dma_buf->skb)
		dma_buf->skb = alloc_skb(dma_buf->len, GFP_ATOMIC);
		if (dma_buf->skb && !dma_buf->dma) {
		dma_buf->skb->dev = adapter->dev;
		if (dma_buf->skb && !dma_buf->dma)
		dma_buf->dma = pci_map_single(
		adapter->pdev,
		skb_tail_pointer(dma_buf->skb),
		dma_buf->len,
		PCI_DMA_FROMDEVICE);
		}

		/* Set descriptor. */
		set_rx_buf(desc, dma_buf->dma);

Admin message