Commit b06ae148 authored Jul 10, 2017 by Arvind Yadav Committed by Dmitry Torokhov Jul 12, 2017

Input: ims-pcu - constify attribute_group structures



attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  13547	   1600	      0	  15147	   3b2b	drivers/input/misc/ims-pcu.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  13675	   1472	      0	  15147	   3b2b	drivers/input/misc/ims-pcu.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 0d4b8e36

drivers/input/misc/ims-pcu.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1261,7 +1261,7 @@ static umode_t ims_pcu_is_attr_visible(struct kobject *kobj,
		return mode;
		}

		static struct attribute_group ims_pcu_attr_group = {
		static const struct attribute_group ims_pcu_attr_group = {
		.is_visible = ims_pcu_is_attr_visible,
		.attrs = ims_pcu_attrs,
		};
		@@ -1480,7 +1480,7 @@ static struct attribute *ims_pcu_ofn_attrs[] = {
		NULL
		};

		static struct attribute_group ims_pcu_ofn_attr_group = {
		static const struct attribute_group ims_pcu_ofn_attr_group = {
		.name = "ofn",
		.attrs = ims_pcu_ofn_attrs,
		};

Admin message